✨ Add packaging workflow for semantic-release #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travi
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
Signed-off-by: Matt Travi <[email protected]>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
+ Coverage 53.01% 53.05% +0.03%
==========================================
Files 161 161
Lines 12303 12312 +9
==========================================
+ Hits 6523 6532 +9
Misses 5404 5404
Partials 376 376 |
spencerschrock
approved these changes
May 8, 2023
Signed-off-by: Matt Travi <[email protected]>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Yes, Scorecard doesn't currently follow any reusable workflows.
Thank you for the contribution! |
makes sense. thank you for confirming. would you say that there is an appetite to analyze those at some point in the future?
absolutely. thanks for accepting and for all you do on the project. i'm excited about how this will help our communities |
gabibguti
pushed a commit
to gabibguti/scorecard
that referenced
this pull request
May 10, 2023
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <[email protected]> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <[email protected]> --------- Signed-off-by: Matt Travi <[email protected]>
This was referenced May 11, 2023
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <[email protected]> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <[email protected]> --------- Signed-off-by: Matt Travi <[email protected]> Signed-off-by: Avishay <[email protected]>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <[email protected]> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <[email protected]> --------- Signed-off-by: Matt Travi <[email protected]> Signed-off-by: Allen Shearin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds detection for the recommended use of semantic-release in a GitHub Actions workflow.
What is the current behavior?
semantic-releaseis not detected as a packaging tool. detection forpython-semantic-releasewas added in #1654, but that is a separate project fromsemantic-releaseWhat is the new behavior (if this is a feature change)?**
semantic-releaseis now detected when used with npx in the workflow. the following variations are detected in therunproperty of a step:npx semantic-releasenpx semantic-release@21npx [email protected]npx semantic-release@betanpx -p @semantic-release/git semantic-releaseI verified that the variations above are detected when set in the testdata workflow file, but the PR currently only contains one of those variations. I did not find examples of other situations that defined multiple workflow variations for a single packaging tool detection, but I am open to feedback if additional tests would be desired.
Which issue(s) this PR fixes
Fixes #2929
Special notes for your reviewer
i personally use a reusable workflow (example reference) to capture the details of running
semantic-release. (Since I am asemantic-releasemaintainer, I mostly do this to enable easy switching from use of the latest version to a pre-release in order to test further across my own projects.) I assume reusable workflows would prevent detection of thesemantic-releaseusage, is that correct or does the scanning also evaluate those?even if reusable workflows are not scanned, adding this detection would be valuable for much of our community. i would be interested to add this support and follow up with further discussion afterward about reusable workflows if not already scanned.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)